Messages in this thread | | | Date | Sat, 25 Aug 2012 01:40:22 +0900 | Subject | Re: [PATCH 2/2] slub: correct the calculation of the number of cpu objects in get_partial_node | From | JoonSoo Kim <> |
| |
2012/8/25 Christoph Lameter <cl@linux.com>: > On Sat, 25 Aug 2012, JoonSoo Kim wrote: > >> But, when using "cpu_partial_objects", I have a coding style problem. >> >> if (kmem_cache_debug(s) >> || cpu_slab_objects + cpu_partial_objects >> > s->max_cpu_object / 2) >> >> Do you have any good idea? > > Not sure what the problem is? The line wrap?
Yes! The line wrap.
if (kmem_cache_debug(s) || cpu_slab_objects + cpu_partial_objects > s->max_cpu_object / 2) break;
Above example use 82 columns... The line wrapping problem.
if (kmem_cache_debug(s) || cpu_slab_objects + cpu_partial_objects > s->max_cpu_object / 2) break;
This one use 79 columns, but somehow ugly because second line start at same column of above line. Is it okay?
if (kmem_cache_debug(s) || cpu_slab_objects + cpu_partial_objects > s->max_cpu_object / 2) break;
Is it the best? It use 72 columns. Let me know what is the best method for this situation.
Thanks!
| |