Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver. | Date | Fri, 24 Aug 2012 13:41:04 +0200 |
| |
On Friday 24 August 2012 11:37:45 Yann Cantin wrote: > Hi, > > Le 23/08/2012 09:23, Oliver Neukum a écrit : > > On Thursday 23 August 2012 00:11:54 Yann Cantin wrote:
> > These functions are identical. You should unify them. > > Removed reset_resume from the driver (optional, and not needed > for this hardware).
Why did you do that? It is always better to have reset_resume(). And you cannot tell whether it will be needed.
Regards Oliver
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |