Messages in this thread | | | Date | Thu, 23 Aug 2012 16:14:24 -0700 (PDT) | From | Hugh Dickins <> | Subject | Re: [PATCH v7 1/4] xattr: extract simple_xattr code from tmpfs |
| |
On Thu, 23 Aug 2012, aris@redhat.com wrote: > From: Li Zefan <lizefan@huawei.com> > > Extract in-memory xattr APIs from tmpfs. Will be used by cgroup. > > $ size vmlinux.o > text data bss dec hex filename > 4658782 880729 5195032 10734543 a3cbcf vmlinux.o > $ size vmlinux.o > text data bss dec hex filename > 4658957 880729 5195032 10734718 a3cc7e vmlinux.o > > v7: > - checkpatch warnings fixed > - Implement the changes requested by Hugh Dickins: > - make simple_xattrs_init and simple_xattrs_free inline > - get rid of locking and list reinitialization in simple_xattrs_free, > they're not needed
Thanks for doing those.
I'm also happy to see that you're now using simple_xattr_alloc() in __simple_xattr_set() (but no need to respin to comment on that here).
It looks very nice: much better for this code to live in fs/xattr.c than in mm/shmem.c.
> v6: > - no changes > v5: > - no changes > v4: > - move simple_xattrs_free() to fs/xattr.c > v3: > - in kmem_xattrs_free(), reinitialize the list > - use simple_xattr_* prefix > - introduce simple_xattr_add() to prevent direct list usage > > Cc: Li Zefan <lizefan@huawei.com> > Cc: Tejun Heo <tj@kernel.org> > Cc: Hugh Dickins <hughd@google.com>
Acked-by: Hugh Dickins <hughd@google.com>
> Cc: Hillf Danton <dhillf@gmail.com> > Cc: Lennart Poettering <lpoetter@redhat.com> > Signed-off-by: Li Zefan <lizefan@huawei.com> > Signed-off-by: Aristeu Rozanski <aris@redhat.com>
| |