lkml.org 
[lkml]   [2012]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] drivers/video/auo_k190x.c: drop kfree of devm_kzalloc's data
On 08/04/2012 12:00 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Using kfree to free data allocated with devm_kzalloc causes double frees.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x;
> @@
>
> x = devm_kzalloc(...)
> ...
> ?-kfree(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied.


Thanks,

Florian Tobias Schandinat

>
> ---
> drivers/video/auo_k190x.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/auo_k190x.c b/drivers/video/auo_k190x.c
> index 77da6a2..c03ecdd 100644
> --- a/drivers/video/auo_k190x.c
> +++ b/drivers/video/auo_k190x.c
> @@ -987,7 +987,6 @@ err_regfb:
> fb_dealloc_cmap(&info->cmap);
> err_cmap:
> fb_deferred_io_cleanup(info);
> - kfree(info->fbdefio);
> err_defio:
> vfree((void *)info->screen_base);
> err_irq:
> @@ -1022,7 +1021,6 @@ int __devexit auok190x_common_remove(struct platform_device *pdev)
> fb_dealloc_cmap(&info->cmap);
>
> fb_deferred_io_cleanup(info);
> - kfree(info->fbdefio);
>
> vfree((void *)info->screen_base);
>
>
>



\
 
 \ /
  Last update: 2012-08-23 23:21    [W:0.322 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site