Messages in this thread | | | Date | Thu, 23 Aug 2012 23:39:51 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH] max8907: fix use of possibly NULL idata |
| |
On Thursday 23 August 2012 11:55 PM, Stephen Warren wrote: > On 08/23/2012 12:19 PM, Stephen Warren wrote: > Laxman, > > The TPS6586x driver avoids this NULL-dereference issue by simply not > registering any regulators when idata is NULL. See > drivers/mfd/tps6586x.c:tps6586x_parse_dt(): > >> for (i = 0, j = 0; i< num&& j< count; i++) { >> struct regulator_init_data *reg_idata; >> >> if (!tps6586x_matches[i].init_data) >> continue; > If I interpreted Mark Brown correctly, this isn't correct; all the > regulators within the chip should always be registered, just without any > user-supplied constraints. Assuming I didn't misinterpret Mark, can you > please fix the TPS6586x driver to always register the regulators, and > apply the fix below. Could you please check the TPS65911 driver and see > what the status is there too? Thanks very much!
Sure, I will check it.
| |