Messages in this thread | | | Date | Thu, 23 Aug 2012 22:34:18 +1000 | From | Greg Ungerer <> | Subject | Re: [PATCH 1/3] Add support to broadcom 5222 PHY |
| |
Hi Stany,
On 08/23/2012 08:47 PM, Geert Uytterhoeven wrote: > On Tue, Aug 21, 2012 at 2:18 PM, Stany MARCEL > <stany.marcel@novasys-ingenierie.com> wrote: >> Signed-off-by: Stany MARCEL <stany.marcel@novasys-ingenierie.com> >> --- >> >> This driver is an adaption of the one given by freescale for kernel 2.6.25. >> >> Tested with kernel 3.4.8 with arch/m68k backported from linux-m68k head >> 2 FEC configured with shared phy >> >> drivers/net/phy/Kconfig | 7 +- >> drivers/net/phy/Makefile | 1 + >> drivers/net/phy/broadcom522x.c | 171 ++++++++++++++++++++++++++++++++++++++++ > > This patch and "[PATCH 3/3] Add support to M54xx DMA FEC Driver" need to go > through the netdev tree, or collect acks there.
And patch 2/3 never made it to the linux-m68k list. Though I can see that it made it onto the linux-kernel list.
I would suggest running them through checkpatch, there is a number of formating and the like issues that need cleaning up.
Also you will want to break up patch 2. It is a bit large to be reviewed the way it is.
Regards Greg
> Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe linux-m68k" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
-- ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close, FAX: +61 7 3891 3630 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
| |