lkml.org 
[lkml]   [2012]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] twl4030_charger: use IRQF_ONESHOT
On Thu, Aug 23, 2012 at 07:56:43PM +0800, Fengguang Wu wrote:
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
> Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

makes sense, NULL hardirq handler:

Acked-by: Felipe Balbi <balbi@ti.com>

> ---
>
> Please take the patch only if it's a positive warning. Thanks!
>
> drivers/power/twl4030_charger.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux.orig/drivers/power/twl4030_charger.c 2012-08-03 15:36:21.615560783 +0800
> +++ linux/drivers/power/twl4030_charger.c 2012-08-23 19:53:21.737195171 +0800
> @@ -534,7 +534,7 @@ static int __init twl4030_bci_probe(stru
> }
>
> ret = request_threaded_irq(bci->irq_chg, NULL,
> - twl4030_charger_interrupt, 0, pdev->name, bci);
> + twl4030_charger_interrupt, IRQF_ONESHOT, pdev->name, bci);
> if (ret < 0) {
> dev_err(&pdev->dev, "could not request irq %d, status %d\n",
> bci->irq_chg, ret);
> @@ -542,7 +542,7 @@ static int __init twl4030_bci_probe(stru
> }
>
> ret = request_threaded_irq(bci->irq_bci, NULL,
> - twl4030_bci_interrupt, 0, pdev->name, bci);
> + twl4030_bci_interrupt, IRQF_ONESHOT, pdev->name, bci);
> if (ret < 0) {
> dev_err(&pdev->dev, "could not request irq %d, status %d\n",
> bci->irq_bci, ret);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-08-23 14:41    [W:0.052 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site