Messages in this thread Patch in this message | | | Date | Thu, 23 Aug 2012 19:56:43 +0800 | From | Fengguang Wu <> | Subject | [PATCH] twl4030_charger: use IRQF_ONESHOT |
| |
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> ---
Please take the patch only if it's a positive warning. Thanks!
drivers/power/twl4030_charger.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- linux.orig/drivers/power/twl4030_charger.c 2012-08-03 15:36:21.615560783 +0800 +++ linux/drivers/power/twl4030_charger.c 2012-08-23 19:53:21.737195171 +0800 @@ -534,7 +534,7 @@ static int __init twl4030_bci_probe(stru } ret = request_threaded_irq(bci->irq_chg, NULL, - twl4030_charger_interrupt, 0, pdev->name, bci); + twl4030_charger_interrupt, IRQF_ONESHOT, pdev->name, bci); if (ret < 0) { dev_err(&pdev->dev, "could not request irq %d, status %d\n", bci->irq_chg, ret); @@ -542,7 +542,7 @@ static int __init twl4030_bci_probe(stru } ret = request_threaded_irq(bci->irq_bci, NULL, - twl4030_bci_interrupt, 0, pdev->name, bci); + twl4030_bci_interrupt, IRQF_ONESHOT, pdev->name, bci); if (ret < 0) { dev_err(&pdev->dev, "could not request irq %d, status %d\n", bci->irq_bci, ret);
| |