Messages in this thread Patches in this message | | | Date | Thu, 23 Aug 2012 19:42:29 +0800 | From | Fengguang Wu <> | Subject | [PATCH] lp8727_charger: use IRQF_ONESHOT |
| |
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> ---
Note: I don't really know much about the situation, feel free to ignore it if it's an false warning.
cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/power/lp8727_charger.c +++ b/drivers/power/lp8727_charger.c @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8 return request_threaded_irq(pchg->client->irq, NULL, lp8727_isr_func, - IRQF_TRIGGER_FALLING, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "lp8727_irq", pchg); }[PATCH] lp8727_charger: fix coccinelle warnings
/c/kernel-tests/src/linux/drivers/power/lp8727_charger.c:255:8-28: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- cocci-output-25411-2ae2e0-lp8727_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/power/lp8727_charger.c +++ b/drivers/power/lp8727_charger.c @@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8 return request_threaded_irq(pchg->client->irq, NULL, lp8727_isr_func, - IRQF_TRIGGER_FALLING, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "lp8727_irq", pchg); } | |