Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for | Date | Wed, 22 Aug 2012 06:44:17 +0000 |
| |
On Wednesday 22 August 2012, Tony Prisk wrote: > The original patch was very simple, but I revisited it to fix other > issues and forgot to add the relevant comments. > > Port size is changed to fix a problem - WM8505 actually had 6 uart's > defined in platform data but the vt8500_ports variable was only 4. > > I have added devicetree port id support as well.
If you do multiple things in one driver, you should normally send multiple patches as well, each with a description why that change is done. It may seem silly at first to send out a one-line patch next to a 100-line patch for the same file, but those cases are actually the ones where it's most important.
Arnd
| |