Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH] tools lib traceevent: Modify header to work in C++ programs | Date | Wed, 22 Aug 2012 15:47:50 +0900 |
| |
Hi, Steve
On Tue, 21 Aug 2012 19:13:20 -0400, Steven Rostedt wrote: > tools lib traceevent: Modify header to work in C++ programs > > Replace keyword "private" from event-parse.h to allow it to be > used in C++ programs. > > Signed-off-by: Steven Rostedt <rostedt@goodmis.org> > > diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h > index 5772ad8..c28713b 100644 > --- a/tools/lib/traceevent/event-parse.h > +++ b/tools/lib/traceevent/event-parse.h > @@ -49,7 +49,7 @@ struct pevent_record { > int cpu; > int ref_count; > int locked; /* Do not free, even if ref_count is zero */ > - void *private; > + void *r_private;
This r_ (and p_) prefix make it inconsistent with others. How about simply using 'priv' instead?
Thanks, Namhyung
> #if DEBUG_RECORD > struct pevent_record *prev; > struct pevent_record *next; > @@ -106,7 +106,7 @@ struct plugin_option { > char *plugin_alias; > char *description; > char *value; > - void *private; > + void *p_private; > int set; > }; >
| |