lkml.org 
[lkml]   [2012]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 12/13] block: Add bio_clone_bioset(), bio_clone_kmalloc()
    On Wed, Aug 22, 2012 at 10:04:09AM -0700, Kent Overstreet wrote:
    > Previously, there was bio_clone() but it only allocated from the fs bio
    > set; as a result various users were open coding it and using
    > __bio_clone().
    >
    > This changes bio_clone() to become bio_clone_bioset(), and then we add
    > bio_clone() and bio_clone_kmalloc() as wrappers around it, making use of
    > the functionality the last patch adedd.
    >
    > This will also help in a later patch changing how bio cloning works.

    I'd prefer simply adding @bioset to bio_clone() so that the caller
    always has to make the choice consciously. We're updating all the
    callers anyway.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2012-08-22 23:41    [W:4.286 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site