lkml.org 
[lkml]   [2012]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: Fix 'No libunwind found' make warning message

* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 2012-08-22 at 10:40 +0200, Ingo Molnar wrote:
> >
> > > FLAGS_UNWIND=$(LIBUNWIND_CFLAGS) $(ALL_CFLAGS) $(LIBUNWIND_LDFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) $(LIBUNWIND_LIBS)
> > > ifneq ($(call try-cc,$(SOURCE_LIBUNWIND),$(FLAGS_UNWIND)),y)
> > > - msg := $(warning No libunwind found. Please install libunwind >= 0.99);
> > > + msg := $(warning No libunwind found, disables post unwind support. Please install libunwind-dev[el] >= 0.99);
> >
> > s/disables/disable
>
> Is it a command for the user to do, or something it is about to do for
> the user? If the latter, then "disabling" may be the better word.

Yeah, agreed 'disabling' is even better.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-08-22 17:01    [W:0.076 / U:1.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site