Messages in this thread Patch in this message | | | Date | Wed, 22 Aug 2012 10:38:12 +0200 | From | Jiri Olsa <> | Subject | [PATCH] perf tools: Fix 'No libunwind found' make warning message |
| |
On Tue, Aug 21, 2012 at 11:36:28AM +0200, Jiri Olsa wrote: > On Tue, Aug 21, 2012 at 11:32:31AM +0200, Ingo Molnar wrote: > > > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > > > > SNIP > > > > > One minor observation, the Makefile tells us: > > > > Makefile:496: No libunwind found. Please install libunwind >= 0.99 > > > > I guess that should be libunwind-dev[el], right? Plain libunwind > > is not enough. > > right, will fix it > > thanks, > jirka
--- Changing error message when libunwind support is not found to inform properly to install libunwind-dev[el] package.
Reported-by: Ingo Molnar <mingo@elte.hu> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Signed-off-by: Jiri Olsa <jolsa@redhat.com> --- tools/perf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile index 6bd888d..218cdb5 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -493,7 +493,7 @@ endif FLAGS_UNWIND=$(LIBUNWIND_CFLAGS) $(ALL_CFLAGS) $(LIBUNWIND_LDFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) $(LIBUNWIND_LIBS) ifneq ($(call try-cc,$(SOURCE_LIBUNWIND),$(FLAGS_UNWIND)),y) - msg := $(warning No libunwind found. Please install libunwind >= 0.99); + msg := $(warning No libunwind found, disables post unwind support. Please install libunwind-dev[el] >= 0.99); NO_LIBUNWIND := 1 endif # Libunwind support endif # NO_LIBUNWIND -- 1.7.11.4
| |