Messages in this thread Patch in this message | | | From | "Kim, Milo" <> | Subject | [PATCH 2/4] leds-lp5523: set the brightness to 0 forcely on removing the driver | Date | Tue, 21 Aug 2012 09:03:50 +0000 |
| |
Turning off the brightness of each channel is required when removing the driver.
So use flush_work_sync() rather than cancel_work_sync() to wait for unhandled brightness works.
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com> --- drivers/leds/leds-lp5523.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 9fd9a92..f090819 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -974,7 +974,7 @@ static int __devinit lp5523_probe(struct i2c_client *client, fail2: for (i = 0; i < chip->num_leds; i++) { led_classdev_unregister(&chip->leds[i].cdev); - cancel_work_sync(&chip->leds[i].brightness_work); + flush_work_sync(&chip->leds[i].brightness_work); } fail1: if (pdata->enable) @@ -993,7 +993,7 @@ static int lp5523_remove(struct i2c_client *client) for (i = 0; i < chip->num_leds; i++) { led_classdev_unregister(&chip->leds[i].cdev); - cancel_work_sync(&chip->leds[i].brightness_work); + flush_work_sync(&chip->leds[i].brightness_work); } if (chip->pdata->enable) -- 1.7.2.5
Best Regards, Milo
| |