Messages in this thread | | | Date | Tue, 21 Aug 2012 23:12:55 +0100 | From | Alan Cox <> | Subject | Re: [PATCHv3 3/9] serial: vt8500: Add devicetree support for vt8500-serial |
| |
On Wed, 22 Aug 2012 08:47:32 +1200 Tony Prisk <linux@prisktech.co.nz> wrote:
> Signed-off-by: Tony Prisk <linux@prisktech.co.nz> > --- > drivers/tty/serial/vt8500_serial.c | 37 ++++++++++++++++++++++++++++++++---- > 1 file changed, 33 insertions(+), 4 deletions(-)
Can we have a comment attached to a change this size. In particular one describing why it gone from 4 to 6 ports, and why the port id twiddling.
Is there a reason you can't use the device tree port id ?
What are the regression risks for existing users expecting the pdev->id binding ?
| |