lkml.org 
[lkml]   [2012]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3 1/2] XEN/X86: Improve semantic support for pagetable_reserve PVOPS
Date
- Allow xen_mapping_pagetable_reserve() to handle a start different from
pgt_buf_start, but still bigger than it.
- Add checks to xen_mapping_pagetable_reserve() and native_pagetable_reserve()
for verifying start and end are contained in the range
[pgt_buf_start, pgt_buf_top].
- In xen_mapping_pagetable_reserve(), change printk into pr_debug.
- In xen_mapping_pagetable_reserve(), print out diagnostic only if there is
an actual need to do that (or, in other words, if there are actually some
pages going to switch from RO to RW).

Signed-off-by: Attilio Rao <attilio.rao@citrix.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
arch/x86/mm/init.c | 4 ++++
arch/x86/xen/mmu.c | 22 ++++++++++++++++++++--
2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
index e0e6990..f4b750d 100644
--- a/arch/x86/mm/init.c
+++ b/arch/x86/mm/init.c
@@ -92,6 +92,10 @@ static void __init find_early_table_space(struct map_range *mr, unsigned long en

void __init native_pagetable_reserve(u64 start, u64 end)
{
+ if (start < PFN_PHYS(pgt_buf_start) || end > PFN_PHYS(pgt_buf_top))
+ panic("Invalid address range: [%#llx-%#llx] should be a subset of [%#llx-%#llx]\n",
+ start, end, (u64)PFN_PHYS(pgt_buf_start),
+ (u64)PFN_PHYS(pgt_buf_top));
memblock_reserve(start, end - start);
}

diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index b65a761..dfae43a 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -1180,12 +1180,30 @@ static void __init xen_pagetable_setup_start(pgd_t *base)

static __init void xen_mapping_pagetable_reserve(u64 start, u64 end)
{
+ u64 begin;
+
+ begin = PFN_PHYS(pgt_buf_start);
+
+ if (start < begin || end > PFN_PHYS(pgt_buf_top))
+ panic("Invalid address range: [%#llx-%#llx] should be a subset of [%#llx-%#llx]\n",
+ start, end, begin, (u64)PFN_PHYS(pgt_buf_top));
+
+ /* set RW the initial range */
+ if (start != begin)
+ pr_debug("xen: setting RW the range [%#llx-%#llx]\n",
+ begin, start);
+ while (begin < start) {
+ make_lowmem_page_readwrite(__va(begin));
+ begin += PAGE_SIZE;
+ }
+
/* reserve the range used */
native_pagetable_reserve(start, end);

/* set as RW the rest */
- printk(KERN_DEBUG "xen: setting RW the range %llx - %llx\n", end,
- PFN_PHYS(pgt_buf_top));
+ if (end != PFN_PHYS(pgt_buf_top))
+ pr_debug("xen: setting RW the range [%#llx-%#llx]\n",
+ end, (u64)PFN_PHYS(pgt_buf_top));
while (end < PFN_PHYS(pgt_buf_top)) {
make_lowmem_page_readwrite(__va(end));
end += PAGE_SIZE;
--
1.7.2.5


\
 
 \ /
  Last update: 2012-08-21 21:21    [W:0.044 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site