Messages in this thread | | | Date | Tue, 21 Aug 2012 17:29:18 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back |
| |
On Tue, Aug 21, 2012 at 10:42:57AM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: > > The VT-d implementation uses it. This function is used to create the MSI > > message for PCI devices and the HPET. When it is called for the HPET the > > pdev parameter is NULL and hpet_id is valid. > > Perhaps then a more generic term? 'void *platform_priv' ?
Doesn't work this way here. The Intel code detects on pdev==NULL that it needs to use hpet_id. What could work is to split the code-paths between pci_dev msi composition and the one for hpet. But that approach has the downside of code duplication to some degree.
Regards,
Joerg
-- AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
| |