Messages in this thread | | | Date | Tue, 21 Aug 2012 16:27:53 +0100 | From | Stefano Stabellini <> | Subject | Re: [Xen-devel] [PATCH 11/11] xen/mmu: Release just the MFN list, not MFN list and part of pagetables. |
| |
On Tue, 21 Aug 2012, Konrad Rzeszutek Wilk wrote: > On Tue, Aug 21, 2012 at 03:18:26PM +0100, Stefano Stabellini wrote: > > On Thu, 16 Aug 2012, Konrad Rzeszutek Wilk wrote: > > > We call memblock_reserve for [start of mfn list] -> [PMD aligned end > > > of mfn list] instead of <start of mfn list> -> <page aligned end of mfn list]. > > > > > > This has the disastrous effect that if at bootup the end of mfn_list is > > > not PMD aligned we end up returning to memblock parts of the region > > > past the mfn_list array. And those parts are the PTE tables with > > > the disastrous effect of seeing this at bootup: > > > > This patch looks wrong to me. > > Its easier to see if you stick the patch in the code. The size = part > was actually also done earlier.
Yes, you are right, I see that know.
| |