Messages in this thread | | | Date | Tue, 21 Aug 2012 17:41:46 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 17/19] x86, msi: Introduce x86_msi.compose_msi_msg call-back |
| |
On Tue, Aug 21, 2012 at 10:42:57AM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Aug 21, 2012 at 10:40:07AM +0200, Joerg Roedel wrote: > > On Mon, Aug 20, 2012 at 10:08:44AM -0400, Konrad Rzeszutek Wilk wrote: > > > On Mon, Aug 20, 2012 at 03:56:03PM +0200, Joerg Roedel wrote: > > > > This call-back points to the right function for initializing > > > > the msi_msg structure. > > > > > > What is the 'hpet_id' purpose in this? > > > > The VT-d implementation uses it. This function is used to create the MSI > > message for PCI devices and the HPET. When it is called for the HPET the > > pdev parameter is NULL and hpet_id is valid. > > Perhaps then a more generic term? 'void *platform_priv' ?
Well, the best approach is probably to remove both, the pdev and the hpet parameter and replace it with an req_id parameter that is passed down instead. IOMMU code needs to expose the hpet request-ids then with another call-back. But that is cleaner than the current compose_msi_msg call-back.
Joerg
-- AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
| |