lkml.org 
[lkml]   [2012]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v8 1/5] mm: introduce a common interface for balloon pages mobility
From
Date
On Tue, 2012-08-21 at 09:47 -0300, Rafael Aquini wrote:
> + mapping = rcu_access_pointer(page->mapping);
> + if (mapping)
> + mapping = mapping->assoc_mapping;

The comment near rcu_access_pointer() explicitly says:

* Return the value of the specified RCU-protected pointer, but omit the
* smp_read_barrier_depends() and keep the ACCESS_ONCE(). This is useful
* when the value of this pointer is accessed, but the pointer is not
* dereferenced,

Yet you dereference the pointer... smells like fail to me.


\
 
 \ /
  Last update: 2012-08-21 18:21    [W:0.199 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site