Messages in this thread | | | Subject | Re: [PATCH v8 1/5] mm: introduce a common interface for balloon pages mobility | From | Peter Zijlstra <> | Date | Tue, 21 Aug 2012 17:20:11 +0200 |
| |
On Tue, 2012-08-21 at 09:47 -0300, Rafael Aquini wrote: > + mapping = rcu_access_pointer(page->mapping); > + if (mapping) > + mapping = mapping->assoc_mapping;
The comment near rcu_access_pointer() explicitly says:
* Return the value of the specified RCU-protected pointer, but omit the * smp_read_barrier_depends() and keep the ACCESS_ONCE(). This is useful * when the value of this pointer is accessed, but the pointer is not * dereferenced,
Yet you dereference the pointer... smells like fail to me.
| |