Messages in this thread | | | Date | Tue, 21 Aug 2012 12:06:12 +0300 | From | Felipe Balbi <> | Subject | Re: [PATCH 3/3] spi: omap2-mcspi: At remove dont use the runtime_autosuspend calls |
| |
On Tue, Aug 21, 2012 at 11:47:44AM +0530, Shubhrajyoti D wrote: > At remove we shouldnt be using the autosuspend timeout as we are > calling pm_runtime_disable immediately after. > > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
Makes sense to me:
Acked-by: Felipe Balbi <balbi@ti.com>
> --- > drivers/spi/spi-omap2-mcspi.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c > index 5642111..f5bf628 100644 > --- a/drivers/spi/spi-omap2-mcspi.c > +++ b/drivers/spi/spi-omap2-mcspi.c > @@ -1243,8 +1243,7 @@ static int __devexit omap2_mcspi_remove(struct platform_device *pdev) > mcspi = spi_master_get_devdata(master); > dma_channels = mcspi->dma_channels; > > - pm_runtime_mark_last_busy(mcspi->dev); > - pm_runtime_put_autosuspend(mcspi->dev); > + pm_runtime_put_sync(mcspi->dev); > pm_runtime_disable(&pdev->dev); > > spi_unregister_master(master); > -- > 1.7.5.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- balbi [unhandled content-type:application/pgp-signature] | |