lkml.org 
[lkml]   [2012]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 09/20] staging: comedi: adv_pci1723: fix initial dio subdevice state and io_bits
On Monday, August 20, 2012 2:49 PM, Dan Carpenter wrote:
> On Fri, Aug 17, 2012 at 06:17:38PM -0700, H Hartley Sweeten wrote:
>> + if (this_board->n_diochan) {
>> + s = dev->subdevices + subdev;
>
> This pointer math sucks still... I feel like the unreadable code is
> part of what caused this bug.
>
> We don't have to change these all at once. If we fix only one line,
> then at least one line will be readable and that is one more than
> before so *improvement*.

Hello Dan,

I'll work of changing the pointer math to array access.

I'll try to post a big chunk of them today.

Regards,
Hartley



\
 
 \ /
  Last update: 2012-08-21 00:21    [W:0.057 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site