Messages in this thread | | | From | Mike Waychison <> | Date | Mon, 20 Aug 2012 12:17:07 -0700 | Subject | Re: [RFC][PATCH v2 1/3] efivars: Disable external interrupt while holding efivars->lock |
| |
Acked-by: Mike Waychison <mikew@google.com>
> @@ -1101,11 +1107,12 @@ out_free: > void unregister_efivars(struct efivars *efivars) > { > struct efivar_entry *entry, *n; > + unsigned long flags; > > list_for_each_entry_safe(entry, n, &efivars->list, list) { > - spin_lock(&efivars->lock); > + spin_lock_irqsave(&efivars->lock, flags); > list_del(&entry->list); > - spin_unlock(&efivars->lock); > + spin_unlock_irqrestore(&efivars->lock, flags); > efivar_unregister(entry); > } > if (efivars->new_var)
Feel free to remove any other uses of flags where you know that you are being called from process context.
| |