Messages in this thread | | | Date | Thu, 2 Aug 2012 16:17:57 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] uprobes: Ignore unsupported instructions in uprobe_mmap |
| |
Forgot to mention...
On 08/02, Srikar Dronamraju wrote: > > While at it, add a missing put_uprobe() in the path where uprobe_mmap() > races with uprobe_unregister(). > ... > @@ -1051,8 +1051,10 @@ int uprobe_mmap(struct vm_area_struct *vma) > if (ret == -EEXIST) { > ret = 0; > > - if (!is_swbp_at_addr(vma->vm_mm, vaddr)) > + if (!is_swbp_at_addr(vma->vm_mm, vaddr)) { > + put_uprobe(uprobe); > continue; > + }
Yes, this part looks correct.
In fact, I think this is not really correct anyway (wrt counter) but we are going to kill it.
Oleg.
| |