Messages in this thread | | | Date | Sun, 19 Aug 2012 14:07:46 +0400 | Subject | Re: [PATCH 1/5] drivers/net/wireless/ipw2x00/ipw2100.c: introduce missing initialization | From | Stanislav Yakovlev <> |
| |
On 19 August 2012 13:49, Julia Lawall <julia.lawall@lip6.fr> wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > The result of one call to a function is tested, and then at the second call > to the same function, the previous result, and not the current result, is > tested again. > > Also changed &bssid to bssid, at the suggestion of Stanislav Yakovlev. > > The semantic match that finds the first problem is as follows: > > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression ret; > identifier f; > statement S1,S2; > @@ > > *ret = f(...); > if (\(ret != 0\|ret < 0\|ret == NULL\)) S1 > ... when any > *f(...); > if (\(ret != 0\|ret < 0\|ret == NULL\)) S2 > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > v2: changed &bssid to bssid >
Thank you, Julia.
Stanislav.
| |