Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 7/14] drivers/mtd/maps/rbtx4939-flash.c: delete unneeded test | Date | Sun, 19 Aug 2012 10:44:23 +0200 |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr>
Err has only been initialized to 0 at this, so it is not possible that this test can be true.
A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; }
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- drivers/mtd/maps/rbtx4939-flash.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/mtd/maps/rbtx4939-flash.c b/drivers/mtd/maps/rbtx4939-flash.c index 6f52e1f..49c3fe7 100644 --- a/drivers/mtd/maps/rbtx4939-flash.c +++ b/drivers/mtd/maps/rbtx4939-flash.c @@ -100,8 +100,6 @@ static int rbtx4939_flash_probe(struct platform_device *dev) goto err_out; } info->mtd->owner = THIS_MODULE; - if (err) - goto err_out; err = mtd_device_parse_register(info->mtd, NULL, NULL, pdata->parts, pdata->nr_parts);
| |