lkml.org 
[lkml]   [2012]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/31] Disable const sections for PA-RISC
On Sun, Aug 19, 2012 at 04:07:10AM +0200, Andi Kleen wrote:
> > > +config BROKEN_RODATA
> > > + bool
> > > + default y
> >
> > Could you please change this so we have a commonly defined HAVE_BROKEN_RODATA
> > symbol. Then arch's that have broken RO data can select this symbol.
> > If we experience tomorrow that sparc have the same issue then with
> > this patch sparc has to create a local definition of this symbol.
>
> Here's an updated patch with the config placed in init/Kconfig.

Looks good!

> I'm not going to repost the whole series.
>
> -Andi
>
> ---
>
> Disable const sections for PA-RISC v2
>
> The PA-RISC tool chain seems to have some problem with correct read/write
> attributes on sections. This causes problems when the const sections
> are fixed up for other architecture to only contain truly read-only
> data.
>
> Disable const sections for PA-RISC
>
> This can cause a bit of noise with modpost.
>
> v2: Move config to init/Kconfig
> Cc: James.Bottomley@HansenPartnership.com
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Sam


\
 
 \ /
  Last update: 2012-08-19 10:21    [W:0.060 / U:2.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site