Messages in this thread | | | Date | Sat, 18 Aug 2012 10:01:10 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH 1/1 v4] i2c: Add default configuration into the Nomadik I2C driver. |
| |
On Wed, Aug 08, 2012 at 02:11:59PM +0100, Lee Jones wrote: > From: Lee Jones <lee.jones@linaro.org> > Date: Tue, 7 Aug 2012 12:27:24 +0100 > Subject: [PATCH 1/1 v4] i2c/nomadik: Add default configuration into the Nomadik I2C driver
Actually, unlike Linus said, I prefer "i2c: nomadik:"; minor nit, though.
> > At this moment in time there is only one known configuration for the > Nomadik I2C driver. By not holding that configuration in the driver > adds some unnecessary overhead in platform code. The configuration > as already been removed from platform code, this patch checks for any
^^ has ( I fixed it )
> over-riding configurations. If there aren't any, the default is used. > > Cc: linux-i2c@vger.kernel.org > Acked-by: srinidhi kasagar <srinidhi.kasagar@stericsson.com> > Acked-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied to -current, thanks! I added a note from Linus that it is needed because of boot regressions. That is also useful in commit messages.
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |