lkml.org 
[lkml]   [2012]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] sched: remove useless code in yield_to
    On 07/12/2012 10:07 PM, Peter Zijlstra wrote:
    > On Tue, 2012-07-03 at 14:34 +0800, Michael Wang wrote:
    >> From: Michael Wang <wangyun@linux.vnet.ibm.com>
    >>
    >> it's impossible to enter else branch if we have set skip_clock_update
    >> in task_yield_fair(), as yield_to_task_fair() will directly return
    >> true after invoke task_yield_fair().
    >
    > It helps if you CC the guy who wrote the code.. I think you're right,
    > although getting that skip_clock_update crap wrong is annoying.
    >
    > Mike?

    Hi, Peter

    I think Mike also agreed to remove that piece of code, should we action now?

    Regards,
    Michael Wang

    >
    >
    >> Signed-off-by: Michael Wang <wangyun@linux.vnet.ibm.com>
    >> ---
    >> kernel/sched/core.c | 7 -------
    >> 1 files changed, 0 insertions(+), 7 deletions(-)
    >>
    >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
    >> index 9bb7d28..77c14aa 100644
    >> --- a/kernel/sched/core.c
    >> +++ b/kernel/sched/core.c
    >> @@ -4737,13 +4737,6 @@ again:
    >> */
    >> if (preempt && rq != p_rq)
    >> resched_task(p_rq->curr);
    >> - } else {
    >> - /*
    >> - * We might have set it in task_yield_fair(), but are
    >> - * not going to schedule(), so don't want to skip
    >> - * the next update.
    >> - */
    >> - rq->skip_clock_update = 0;
    >> }
    >>
    >> out:
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/
    >



    \
     
     \ /
      Last update: 2012-08-17 09:41    [W:3.690 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site