lkml.org 
[lkml]   [2012]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH 01/11] xen/p2m: Fix the comment describing the P2M tree.
On Thu, 16 Aug 2012, Konrad Rzeszutek Wilk wrote:
> It mixed up the p2m_mid_missing with p2m_missing. Also
> remove some extra spaces.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>


Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

> arch/x86/xen/p2m.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
> index 64effdc..e4adbfb 100644
> --- a/arch/x86/xen/p2m.c
> +++ b/arch/x86/xen/p2m.c
> @@ -22,7 +22,7 @@
> *
> * P2M_PER_PAGE depends on the architecture, as a mfn is always
> * unsigned long (8 bytes on 64-bit, 4 bytes on 32), leading to
> - * 512 and 1024 entries respectively.
> + * 512 and 1024 entries respectively.
> *
> * In short, these structures contain the Machine Frame Number (MFN) of the PFN.
> *
> @@ -139,11 +139,11 @@
> * / | ~0, ~0, .... |
> * | \---------------/
> * |
> - * p2m_missing p2m_missing
> - * /------------------\ /------------\
> - * | [p2m_mid_missing]+---->| ~0, ~0, ~0 |
> - * | [p2m_mid_missing]+---->| ..., ~0 |
> - * \------------------/ \------------/
> + * p2m_mid_missing p2m_missing
> + * /-----------------\ /------------\
> + * | [p2m_missing] +---->| ~0, ~0, ~0 |
> + * | [p2m_missing] +---->| ..., ~0 |
> + * \-----------------/ \------------/
> *
> * where ~0 is INVALID_P2M_ENTRY. IDENTITY is (PFN | IDENTITY_BIT)
> */
> @@ -423,7 +423,7 @@ static void free_p2m_page(void *p)
> free_page((unsigned long)p);
> }
>
> -/*
> +/*
> * Fully allocate the p2m structure for a given pfn. We need to check
> * that both the top and mid levels are allocated, and make sure the
> * parallel mfn tree is kept in sync. We may race with other cpus, so
> --
> 1.7.7.6
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>


\
 
 \ /
  Last update: 2012-08-17 20:21    [W:0.247 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site