lkml.org 
[lkml]   [2012]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH v2] trace: Move trace event enable from fs_initcall to early_initcall
From
On Fri, Aug 17, 2012 at 12:28 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri, 2012-08-17 at 09:03 -0300, Ezequiel Garcia wrote:
>> This patch splits trace event initialization in two stages:
>> * ftrace enable
>> * sysfs event entry creation
>>
>> This allows to capture trace events from an earlier point
>> by using 'trace_event' kernel parameter and is important
>> to trace boot-up allocations.
>>
>
> This is much better, I'll give it some tests and add it to my 3.7 queue.
>

Great. Is the event_remove() code, okey? I wasn't too sure about this part.

And also: do you think we could try to only early-enable those events
that were setup with 'trace_event' boot parameter?

I tried but couldn't do it without looping through the complete
__start_ftrace_event array and comparing each entry.

Is this even worthy?

Thanks for reviewing,
Ezequiel.


\
 
 \ /
  Last update: 2012-08-17 19:41    [W:0.070 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site