lkml.org 
[lkml]   [2012]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook
On Fri, 17 Aug 2012, Hans de Goede wrote:

> No my patch was a hack to undo the results of the commit causing
> the regression in the IDE case. But Alan's approach clearly is
> much better! Once we are sure drvdata is not used anywhere the
> dev_set_drvdata call could be removed in the place where my
> hack added a second call to it. Note that there are likely
> actual ide drivers using it, without setting it themselves since
> the ide core was setting it. So removing it will require even more
> auditing / checking.

I did search for dev_get_drvdata() calls in drivers/ide; there were no
other calls that retrieved an ide_drive_t value. But I didn't check
anywhere else in the kernel. In fact, I'm not sure where else to look.

Alan Stern



\
 
 \ /
  Last update: 2012-08-17 18:01    [W:0.087 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site