Messages in this thread | | | Subject | Re: [RESEND][PATCH]efi: initialize efi.runtime_version to make query_variable_info/update_capsule workable | From | Matt Fleming <> | Date | Fri, 17 Aug 2012 11:31:33 +0100 |
| |
On Thu, 2012-08-16 at 14:43 -0700, H. Peter Anvin wrote: > On 08/16/2012 12:53 AM, Matt Fleming wrote: > > On Mon, 2012-08-06 at 18:37 +0000, Seiji Aguchi wrote: > >> A value of efi.runtime_version is checked before calling > >> update_capsule()/query_variable_info() as follows. > >> But it isn't initialized anywhere. > >> <snip> > >> static efi_status_t virt_efi_query_variable_info(u32 attr, > >> u64 *storage_space, > >> u64 *remaining_space, > >> u64 *max_variable_size) { > >> if (efi.runtime_version < EFI_2_00_SYSTEM_TABLE_REVISION) > >> return EFI_UNSUPPORTED; > >> <snip> > >> > >> This patch initializes a value of efi.runtime_version at boot time. > >> > >> Acked-by: Matthew Garrett <mjg@redhat.com> > >> Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com> > >> --- > >> arch/x86/platform/efi/efi.c | 1 + > >> 1 files changed, 1 insertions(+), 0 deletions(-) > > > > Thanks, I picked this up just so it doesn't get lost. It will probably > > go to Linus via Peter Anvin. > > > > Should I take that as an Acked-by: on your part?
Yep.
| |