lkml.org 
[lkml]   [2012]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 09/11] memcg: propagate kmem limiting information to children
    On 08/17/2012 01:35 PM, Michal Hocko wrote:
    >>> Above you said "Once enabled, can't be disabled." and now you can
    >>> > > disable it? Say you are a leaf group with non accounted parents. This
    >>> > > will clear the flag and so no further accounting is done. Shouldn't
    >>> > > unlimited mean that we will never reach the limit? Or am I missing
    >>> > > something?
    >>> > >
    >> >
    >> > You are missing something, and maybe I should be more clear about that.
    >> > The static branches can't be disabled (it is only safe to disable them
    >> > from disarm_static_branches(), when all references are gone). Note that
    >> > when unlimited, we flip bits, do a transversal, but there is no mention
    >> > to the static branch.
    > My little brain still doesn't get this. I wasn't concerned about static
    > branches. I was worried about memcg_can_account_kmem which will return
    > false now, doesn't it.
    >

    Yes, it will. If I got you right, you are concerned because I said that
    can't happen. But it will.

    But I never said that can't happen. I said (ok, I meant) the static
    branches can't be disabled.



    \
     
     \ /
      Last update: 2012-08-17 13:01    [W:2.605 / U:1.564 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site