lkml.org 
[lkml]   [2012]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: BUG: unable to handle kernel paging request in usb_match_id()
Date
Bjørn Mork <bjorn@mork.no> writes:
> Fengguang Wu <fengguang.wu@intel.com> writes:
>
>> @@ -779,6 +780,7 @@ static int usb_device_match(struct devic
>> intf = to_usb_interface(dev);
>> usb_drv = to_usb_driver(drv);
>>
>> + pr_info("%s: device %s, driver %s \n", __func__, dev_name(dev), drv->name);
>> id = usb_match_id(intf, usb_drv->id_table);
>> if (id)
>> return 1;
>> [ 1.397745] usb_match_id: id=c1d80820 idVendor=0x18f3 idProduct=0x220
>> [ 1.398834] usbcore: registered new interface driver dvb_usb_dtt200u
>> [ 1.399943] usb_device_match: device 1-0:1.0, driver dvb_usb_nova_t_usb2
>> [ 1.401095] usb_match_id: id=c1d81b6c idVendor=0x2040 idProduct=0x9300
>> [ 1.402195] usb_match_id: id=c1d81b84 idVendor=0x2040 idProduct=0x9301
>> [ 1.403270] usbcore: registered new interface driver dvb_usb_nova_t_usb2
>> [ 1.404158] usb_device_match: device 1-0:1.0, driver dvb_usb_umt_010
>> [ 1.404861] usb_match_id: id=c1d824f4 idVendor=0x15f4 idProduct=0x1
>> [ 1.405547] usb_match_id: id=c1d8250c idVendor=0x15f4 idProduct=0x15
>> [ 1.406326] usbcore: registered new interface driver dvb_usb_umt_010
>> [ 1.407190] usb_device_match: device 1-0:1.0, driver dvb_usb_gl861
>
> Why is dev_name(dev) constant here? That seems more than odd to me. Is
> this really the same interface matching all these drivers?

Stupid me didn't read your debugging printk's properly. You are of
course logging this *before* testing for a match, so everything is as
expected.

But looking at the emi62 driver, I wonder if this will make any
difference:


diff --git a/drivers/usb/misc/emi62.c b/drivers/usb/misc/emi62.c
index ff08015..ae794b9 100644
--- a/drivers/usb/misc/emi62.c
+++ b/drivers/usb/misc/emi62.c
@@ -232,7 +232,7 @@ wraperr:
return err;
}

-static const struct usb_device_id id_table[] __devinitconst = {
+static const struct usb_device_id id_table[] = {
{ USB_DEVICE(EMI62_VENDOR_ID, EMI62_PRODUCT_ID) },
{ } /* Terminating entry */
};


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-08-17 12:01    [W:0.154 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site