Messages in this thread | | | Date | Thu, 16 Aug 2012 09:53:36 +0200 | From | Martin Schwidefsky <> | Subject | Re: [PATCH 1/4] cputime: Generalize CONFIG_VIRT_CPU_ACCOUNTING |
| |
On Wed, 15 Aug 2012 21:09:04 +0200 Frederic Weisbecker <fweisbec@gmail.com> wrote:
> On Wed, Aug 15, 2012 at 05:03:47PM +0200, Martin Schwidefsky wrote: > > On Tue, 14 Aug 2012 16:16:47 +0200 > > Frederic Weisbecker <fweisbec@gmail.com> wrote: > > > > > S390, ia64 and powerpc all define their own version > > > of CONFIG_VIRT_CPU_ACCOUNTING. Generalize the config > > > and its description to a single place to avoid > > > duplication. > > > > For S390 CONFIG_VIRT_CPU_ACCOUNTING is not configurable, it is always > > enabled. With this patch we'd get a config option in the menu, no? > > Indeed it now appears in the menu but in the case of s390, it's impossible > to turn it off due to: > > config S390 > select VIRT_CPU_ACCOUNTING > > This creates a strict dependency that the user can't override. The option > is untoggable.
Hmm, ok. But then the description should be reworded not to be specific to the power architecture (the part of the message about "This also enables accounting of stolen time on logically-partitioned systems running on IBM POWER5-based machines.").
-- blue skies, Martin.
"Reality continues to ruin my life." - Calvin.
| |