lkml.org 
[lkml]   [2012]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 21/31] arm64: 32-bit (compat) applications support
    Date
    On Thursday 16 August 2012, Will Deacon wrote:
    >
    > On Wed, Aug 15, 2012 at 03:34:04PM +0100, Arnd Bergmann wrote:
    > > On Tuesday 14 August 2012, Catalin Marinas wrote:
    > > > +asmlinkage int compat_sys_personality(compat_ulong_t personality)
    > > > +{
    > > > + int ret;
    > > > +
    > > > + if (personality(current->personality) == PER_LINUX32 &&
    > > > + personality == PER_LINUX)
    > > > + personality = PER_LINUX32;
    > > > + ret = sys_personality(personality);
    > > > + if (ret == PER_LINUX32)
    > > > + ret = PER_LINUX;
    > > > + return ret;
    > > > +}
    > >
    > > Where did you get this from?
    > >
    > > You should not need compat_sys_personality, just call the native function.
    >
    > Hmm, but in that case an aarch32 application doing a personality(PER_LINUX)
    > syscall will start seeing the wrong uname.

    Not the wrong uname, just the default one, which is correct.

    Arnd


    \
     
     \ /
      Last update: 2012-08-16 15:22    [W:4.694 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site