lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[v2.6.34-stable 049/165] TPM: Call tpm_transmit with correct size
    Date
    From: Peter Huewe <huewe.external.infineon@googlemail.com>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit 6b07d30aca7e52f2881b8c8c20c8a2cd28e8b3d3 upstream.

    This patch changes the call of tpm_transmit by supplying the size of the
    userspace buffer instead of TPM_BUFSIZE.

    This got assigned CVE-2011-1161.

    [The first hunk didn't make sense given one could expect
    way less data than TPM_BUFSIZE, so added tpm_transmit boundary
    check over bufsiz instead
    The last parameter of tpm_transmit() reflects the amount
    of data expected from the device, and not the buffer size
    being supplied to it. It isn't ideal to parse it directly,
    so we just set it to the maximum the input buffer can handle
    and let the userspace API to do such job.]

    Signed-off-by: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
    Signed-off-by: James Morris <jmorris@namei.org>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/char/tpm/tpm.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
    index 7f95fec..f39e5ee 100644
    --- a/drivers/char/tpm/tpm.c
    +++ b/drivers/char/tpm/tpm.c
    @@ -375,6 +375,9 @@ static ssize_t tpm_transmit(struct tpm_chip *chip, const char *buf,
    u32 count, ordinal;
    unsigned long stop;

    + if (bufsiz > TPM_BUFSIZE)
    + bufsiz = TPM_BUFSIZE;
    +
    count = be32_to_cpu(*((__be32 *) (buf + 2)));
    ordinal = be32_to_cpu(*((__be32 *) (buf + 6)));
    if (count == 0)
    --
    1.7.12.rc2


    \
     
     \ /
      Last update: 2012-08-16 02:03    [W:4.083 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site