Messages in this thread Patch in this message | | | From | Alexey Khoroshilov <> | Subject | [PATCH] [media] ddbridge: fix error handling in module_init_ddbridge() | Date | Thu, 16 Aug 2012 00:42:25 +0400 |
| |
If pci_register_driver() failed, resources allocated in ddb_class_create() are leaked. The patch fixes it.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> --- drivers/media/dvb/ddbridge/ddbridge-core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/media/dvb/ddbridge/ddbridge-core.c b/drivers/media/dvb/ddbridge/ddbridge-core.c index ebf3f05..36aa4e4 100644 --- a/drivers/media/dvb/ddbridge/ddbridge-core.c +++ b/drivers/media/dvb/ddbridge/ddbridge-core.c @@ -1705,7 +1705,11 @@ static __init int module_init_ddbridge(void) "Copyright (C) 2010-11 Digital Devices GmbH\n"); if (ddb_class_create()) return -1; - return pci_register_driver(&ddb_pci_driver); + if (pci_register_driver(&ddb_pci_driver) < 0) { + ddb_class_destroy(); + return -1; + } + return 0; } static __exit void module_exit_ddbridge(void) -- 1.7.9.5
| |