Messages in this thread | | | Date | Wed, 15 Aug 2012 17:45:30 +0100 | From | Catalin Marinas <> | Subject | Re: [PATCH v2 04/31] arm64: MMU definitions |
| |
On Wed, Aug 15, 2012 at 05:34:46PM +0100, Geert Uytterhoeven wrote: > On Wed, Aug 15, 2012 at 3:30 PM, Arnd Bergmann <arnd@arndb.de> wrote: > >> +#define TCR_IPS_40BIT (2 << 32) > > By default, constants are int, i.e. 32-bit. So you must write > > 2ULL << 32 > > >> +#define TCR_ASID16 (1 << 36) > > 1ULL
Those higher constants are only used in assembly currently, so no side-effects. But I agree that I should use something like:
(_AC(1, UL) << 36)
(UL is sufficient on a 64-bit system)
Thanks.
-- Catalin
| |