Messages in this thread | | | Date | Wed, 15 Aug 2012 10:14:38 +0530 | Subject | Re: [PATCH] UDF: During mount free lvid_bh before rescanning with different blocksize | From | Ashish Sangwan <> |
| |
Hi Jan,
> Yeah, I don't think this happens in practice but in theory it could. BTW, > did you check whether we don't need to free other information (like VAT > inode etc.) when rescanning the filesystem? I think we do but currently I'm > catching up after a long vacation and this doesn't have high priority. > Actually, it did happen in practice. That's how we discovered it. Currently, it seems a bug. We formatted a usb stick, sector size 512bytes, using mkudffs with default block size 2KB. While writing to this media we unplug the USB which left lvid in corrupted state. On remounting, first UDF tries to mount the media with sector size and somehow it managed to fill lvid bh but failed to load metadata/mirror fe because of wrong block size. While rescanning with 2KB block size it failed to load the correct lvid as it was corrupted earlier and ended up using the wrong one. After noticing this problem, we did check other info too. Everything else seems to be correct.
> Anyway, I've added your patch to my tree. Thanks. > Thanks for looking into the patch.
Ashish
| |