Messages in this thread | | | Date | Wed, 15 Aug 2012 09:46:31 +0200 | From | Bernhard Froemel <> | Subject | Re: [PATCH V2 2/2] apple_gmux: Add support for newer hardware |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 08/14/2012 07:11 PM, Bernhard Froemel wrote: > Need to play around further.. I think I solved the communication problems concerning byte writes to the gmux device.
This: http://luna.vmars.tuwien.ac.at/~froemel/rmbp/patch-apple-gmux_v2.txt works reliable for me (50+ suspend/resume cycles, many brightness changes) *without* delays.
I looked once more through Apple's original driver and noticed that their cmd_done waits until bit 1 is set (not cleared!) and also does the final read from GMUX_PORT_DPM_RADDR only if bit 1 is not set. Also it seems that in case of byte writes the old interface should be followed as well (Apple, why?!).
Bernhard
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlArU9cACgkQ6iVUjPs37Jk6iACfWuZ7zpbc1vFLgJR29UroJeL2 HvMAnja8D7/o+aqywr/qRtNrB/o217Ci =gcjo -----END PGP SIGNATURE-----
| |