lkml.org 
[lkml]   [2012]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/5] drivers/usb/host/ehci-platform.c: fix error return code
    On Tue, 14 Aug 2012, Julia Lawall wrote:

    > From: Julia Lawall <Julia.Lawall@lip6.fr>
    >
    > Convert a possibly 0 error return code to a negative one, as returned
    > elsewhere in the function.

    ...

    > diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
    > index 91acdde..764e010 100644
    > --- a/drivers/usb/host/ehci-platform.c
    > +++ b/drivers/usb/host/ehci-platform.c
    > @@ -128,8 +128,10 @@ static int __devinit ehci_platform_probe(struct platform_device *dev)
    > }
    >
    > hcd->regs = ioremap_nocache(hcd->rsrc_start, hcd->rsrc_len);
    > - if (!hcd->regs)
    > + if (!hcd->regs) {
    > + err = -ENOMEM;
    > goto err_release_region;
    > + }
    > err = usb_add_hcd(hcd, irq, IRQF_SHARED);
    > if (err)
    > goto err_iounmap;

    Acked-by: Alan Stern <stern@rowland.harvard.edu>



    \
     
     \ /
      Last update: 2012-08-15 17:22    [W:2.967 / U:1.664 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site