Messages in this thread | | | Date | Tue, 14 Aug 2012 09:58:52 +0100 | From | Ian Abbott <> | Subject | Re: [PATCH 1/2 v2] staging: comedi: new adl_pci7x3x driver |
| |
On 2012-08-14 02:36, H Hartley Sweeten wrote: > On Monday, August 13, 2012 6:30 PM, Greg KH wrote: >> On Fri, Aug 03, 2012 at 10:28:18AM -0700, H Hartley Sweeten wrote: >>> Currently the ADLink PCI-7230 and PCI-7432 Isolated Digital >>> I/O Boards are supported using two drivers (adl_pci7230 and >>> adl_pci7432). These drivers are very similar and only differ >>> in the total number of di/do channels provided. >>> >>> This driver combines the support for both boards into one >>> common driver. In addition, it adds PCI PnP support for the >>> other boards in the ADLink PCI-723x and PCI-743x series. >>> >>> This driver only supports the comedi PCI auto config attach >>> mechanism. The legacy attach using the comedi_config utility >>> is not supported or required by this driver. >> >> I now get the following build warnings on my box with this patch >> applied: >> >> drivers/staging/comedi/drivers/adl_pci7x3x.c: In function ‘adl_pci7x3x_do_insn_bits’: >> drivers/staging/comedi/drivers/adl_pci7x3x.c:124:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] >> drivers/staging/comedi/drivers/adl_pci7x3x.c: In function ‘adl_pci7x3x_di_insn_bits’: >> drivers/staging/comedi/drivers/adl_pci7x3x.c:150:21: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > > Hmm.. My build does not have the [-Wpointer-to-int-cast] for some reason > so I didn't see this. I was trying to save having to allocate any private data but > I guess it's cleaner if I do. BTW, there is another comedi driver that does this > but I can't recall which one of the top of my head...
You could always cast to unsigned long as that is the same size as a pointer, at least in the Linux kernel.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |