Messages in this thread Patch in this message | | | From | Mel Gorman <> | Subject | [PATCH 1/5] mm: compaction: Update comment in try_to_compact_pages | Date | Tue, 14 Aug 2012 17:41:28 +0100 |
| |
The comment about order applied when the check was order > PAGE_ALLOC_COSTLY_ORDER which has not been the case since [c5a73c3d: thp: use compaction for all allocation orders]. Fixing the comment while I'm in the general area.
Signed-off-by: Mel Gorman <mgorman@suse.de> Reviewed-by: Rik van Riel <riel@redhat.com> Reviewed-by: Minchan Kim <minchan@kernel.org> --- mm/compaction.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c index 36276e6..ea588eb 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -812,11 +812,7 @@ unsigned long try_to_compact_pages(struct zonelist *zonelist, struct zone *zone; int rc = COMPACT_SKIPPED; - /* - * Check whether it is worth even starting compaction. The order check is - * made because an assumption is made that the page allocator can satisfy - * the "cheaper" orders without taking special steps - */ + /* Check if the GFP flags allow compaction */ if (!order || !may_enter_fs || !may_perform_io) return rc; -- 1.7.9.2
| |