Messages in this thread | | | Date | Wed, 15 Aug 2012 00:22:38 +0200 | From | Jan Kara <> | Subject | Re: Bug in UDF, setting larger file size when data in ICB |
| |
On Mon 23-07-12 17:43:37, Ian Abbott wrote: > On 2012-07-23 16:19, Ian Abbott wrote: > >Hi folks, > > > >in fs/udf/inode.c, udf_setsize(), if the new size is larger than the old > >size and the old data is in the ICB and the new size still fits in the > >ICB (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB and iinfo->i_lenAlloc > >= newsize), udf_extend_file() is called which promptly calls BUG() > >because it does not like this i_alloc_type value. > > > >I think the simplest fix would be to add a 'goto' after the assignment > >to iinfo->i_lenAlloc, bypassing the call to udf_extend_file(). > > Jan is on vacation until early August, so I submitted my own patch: > > Date: Mon, 23 Jul 2012 17:39:29 +0100 > Subject: [PATCH] udf: fix udf_setsize() for file data in ICB > Message-ID: <1343061569-3629-1-git-send-email-abbotti@mev.co.uk> Thanks for the patch. I've added it to my tree and will send it to Linus soon.
Honza
-- Jan Kara <jack@suse.cz> SUSE Labs, CR
| |