Messages in this thread | | | Date | Tue, 14 Aug 2012 22:27:21 +0100 | From | Al Viro <> | Subject | Re: [patch 3/8] procfs: Add ability to plug in auxiliary fdinfo providers |
| |
On Tue, Aug 14, 2012 at 11:56:49PM +0400, Cyrill Gorcunov wrote: > Al, does the patch below looks better? If so I'll fix up the rest.
> struct file_operations { > struct module *owner; > + struct seq_operations *fdinfo_ops;
IDGI. Why on the earth do you need the whole iterator? All it takes is show_fdinfo(struct seq_file *m, struct file *f); have ->show() in your iterator (one going through the files) call that sucker for the file we are trying to show.
I think you are severely overdesigning that thing...
| |