Messages in this thread | | | Date | Wed, 15 Aug 2012 03:04:57 +0900 | Subject | Re: [PATCH 2/5] workqueue: change value of lcpu in queue_delayed_work_on() | From | JoonSoo Kim <> |
| |
> Why not just do > > if (cpu == WORK_CPU_UNBOUND) > cpu = raw_smp_processor_id(); > > if (!(wq->flags...) { > ... > if (gcwq && gcwq->cpu != WORK_CPU_UNBOUND) > lcpu = gcwq->cpu; > else > lcpu = cpu; > } > ... > > add_timer_on(timer, cpu);
I re-look at code deeply and find that dwork->cpu is related to tracing information. If we do above change, tracing information is bias.
> Also, can you please base the patches on top of the following git > branch? > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-3.7
Sure!
| |