Messages in this thread | | | Date | Tue, 14 Aug 2012 10:35:31 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 6/6] workqueue: deprecate WQ_NON_REENTRANT |
| |
Hello,
On Tue, Aug 14, 2012 at 07:24:59PM +0200, Marc Dietrich wrote: > the nvec driver had its own workqueue because we found that it reduced some > timimg induced protocol errors. I just tested your patch which uses the system > workqueue and I failed to reproduce these protocol errors under stress > testing, so I think it's ok.
Thanks, there shouldn't be any difference whether you use system_wq or your own.
> Because this is a single patch affecting many drivers, is this going through > linux-next or some subsystem tree? Maybe it would have been better to split it > in one patch per driver. Otherwise ...
I generally think it's better to do quick one time conversion for things like this, but this patch is rather borderline. It might be better to separate out the non trivialones and route them separately. I'll think more about it.
Thanks.
-- tejun
| |